D2400: stack: begin to make the stack revset configurable

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Mon Mar 19 20:08:38 UTC 2018


indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  I'm not super keen on introducing a new `[stack]` config section. But I don't have any better ideas for where this should go. `[ui]` is my best idea, but I thought we decided we wanted to stop stuffing random stuff into `[ui]`. So I dunno.

INLINE COMMENTS

> stack.py:41-42
> +
> +    finalrevspec = " and ".join(revspec)
> +    revset = revsetlang.formatspec(finalrevspec, *revspecargs)
>      revisions = scmutil.revrange(repo, [revset])

As I review just this patch, I question if we shouldn't just concatenate `and not ::merge()` to the revset string. But I know other changes are coming. I assume the final state justifies the extra complexity.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2400

To: lothiraldan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list