D2909: rebase: remove unused default argument values from conclude[memory]node()

[martinvonz (Martin von Zweigbergk)]

martinvonz created this revision.
martinvonz added a reviewer: phillco.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  It's only "commitmsg" that we don't always pass.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2909

AFFECTED FILES
  hgext/rebase.py

CHANGE DETAILS

diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -1026,9 +1026,8 @@
                      (max(destancestors),
                       ', '.join("%d" % p for p in sorted(parents))))
 
-def concludememorynode(repo, rev, p1, p2, wctx=None,
-                       commitmsg=None, editor=None, extrafn=None,
-                       keepbranches=False, date=None):
+def concludememorynode(repo, rev, p1, p2, wctx, editor, extrafn, keepbranches,
+                       date, commitmsg=None):
     '''Commit the memory changes with parents p1 and p2. Reuse commit info from
     rev but also store useful information in extra.
     Return node of committed revision.'''
@@ -1064,8 +1063,8 @@
         wctx.clean() # Might be reused
         return commitres
 
-def concludenode(repo, rev, p1, p2, commitmsg=None, editor=None, extrafn=None,
-                 keepbranches=False, date=None):
+def concludenode(repo, rev, p1, p2, editor, extrafn, keepbranches, date,
+                 commitmsg=None):
     '''Commit the wd changes with parents p1 and p2. Reuse commit info from rev
     but also store useful information in extra.
     Return node of committed revision.'''



To: martinvonz, phillco, #hg-reviewers
Cc: mercurial-devel