D2909: rebase: remove unused default argument values from conclude[memory]node()

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Mar 21 19:12:03 EDT 2018


indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  I wonder if it is worth creating a dedicated type to represent the fields in a commit. We have a handful of these functions around the code base where you need to pass around a bunch of values as a unit. But that would be follow-up fodder.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2909

To: martinvonz, phillco, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list