D2807: remotenames: add functionality to hoist remotebookmarks

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Mar 21 20:10:27 EDT 2018


indygreg added a comment.


  I like the functionality. I'm not crazy about "hoist." I think if the config option were named `hoistedpeer`, that would be a bit better. If it is just `hoist`, it sounds like it should be a boolean.
  
  `hoistedname` appearing in `hg log` output doesn't feel right. It seems to want a multiple word label. If we kept "hoist," I suppose that would be `hoisted name`. But I'm not crazy about the naming. But I can't think of better terminology right now. I want to incorporate "primary" or "main" somehow. But that terminology doesn't seem to work in the context of an `hg log` label.
  
  With those minor fixups, I'll queue this. I think we can bikeshed the naming later. We can always alias the old config option if we rename things.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2807

To: pulkit, #hg-reviewers, durin42
Cc: indygreg, durin42, mercurial-devel


More information about the Mercurial-devel mailing list