D2692: merge: return an attrs class from update() and applyupdates()

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Mar 21 20:16:04 EDT 2018


martinvonz added inline comments.

INLINE COMMENTS

> merge.py:1403-1404
>  
> + at attr.s(frozen=True)
> +class updateresult(object):
> +    updatedcount = attr.ib()

mpm made me use a tuple with __slots__ for scmutil.status. Any idea when that's better? I think it was something about performance, but we don't care about that here.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2692

To: indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list