D2698: merge: use constants for merge state record types

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Mar 21 20:35:06 EDT 2018


martinvonz added inline comments.

INLINE COMMENTS

> merge.py:50
>  
> +# Merge state record types. See ``mergestate`` docs for more.
> +RECORD_LOCAL = b'L'

Perhaps we should move that documentation to here so we don't have two lists of the same values that can end up getting out of sync? That would also make it easier to review this patch because the descriptions would be right next to the names you picked.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2698

To: indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list