D2858: wireproto: define and implement responses in framing protocol

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Mar 21 21:15:35 EDT 2018


durin42 added inline comments.

INLINE COMMENTS

> wireprotoframing.py:347-349
> +        return 'sendframes', {
> +            'framegen': createbytesresponseframesfrombytes(data),
> +        }

I wonder if we'd be better off with an enumerated set of types that are attr.s instances instead of a dict, but let's not worry about it for now...

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2858

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list