D2871: wireproto: service multiple command requests per HTTP request

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Mar 21 21:26:12 EDT 2018


durin42 added inline comments.

INLINE COMMENTS

> wireprotoserver.py:508
> +
> +        assert authedperm in (b'ro', b'rw')
> +        wirecommand = wireproto.commands[command['command']]

worth not using assert here? I don't think this is attacker-controlled?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2871

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list