[PATCH] remove: add dry-run functionality

Yuya Nishihara yuya at tcha.org
Thu Mar 22 10:19:21 EDT 2018


On Wed, 21 Mar 2018 23:56:55 +0530, Sushil khanchi wrote:
> # HG changeset patch
> # User Sushil khanchi <sushilkhanchi97 at gmail.com>
> # Date 1521655571 -19800
> #      Wed Mar 21 23:36:11 2018 +0530
> # Node ID 35c57ba0cf288af7c232d0bf17ea8dcb01644d09
> # Parent  b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd
> remove: add dry-run functionality

> +def remove(ui, repo, m, prefix, after, force, subrepos, dryrun, warnings=None):
>      join = lambda f: os.path.join(prefix, f)
>      ret = 0
>      s = repo.status(match=m, clean=True)
> @@ -2181,13 +2181,14 @@

Need to pass dryrun to sub.removefiles()

>      opts = pycompat.byteskwargs(opts)
> -    after, force = opts.get('after'), opts.get('force')
> +    after, force = opts.get(r'after'), opts.get(r'force')
> +    dryrun = opts.get(r'dry_run')

No r'' because here opts is {bytes: any}.

>      @annotatesubrepoerror
> -    def removefiles(self, matcher, prefix, after, force, subrepos, warnings):
> +    def removefiles(self, matcher, prefix, after, force, subrepos,
> +                    dryrun, warnings):
>          return cmdutil.remove(self.ui, self._repo, matcher,
>                                self.wvfs.reljoin(prefix, self._path),
> -                              after, force, subrepos)
> +                              after, force, subrepos, dryrun)

Need to update the base class too.

% grep 'def removefiles' mercurial/subrepo.py
    def removefiles(self, matcher, prefix, after, force, subrepos, warnings):
    def removefiles(self, matcher, prefix, after, force, subrepos,


More information about the Mercurial-devel mailing list