D2752: cbor: add a __init__.py to top level cbor module
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Thu Mar 22 11:28:27 EDT 2018
indygreg added a subscriber: alex_gaynor.
indygreg added a comment.
In https://phab.mercurial-scm.org/D2752#45926, @pulkit wrote:
> In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote:
>
> > I think you should send the relative import patches to upstream. Adding `from __future__ import absolute_import` would also be a nice touch.
>
>
> I tried that at https://github.com/agronholm/cbor2/pull/20. I might be doing something wrong here but I am not sure what's that.
I started engaging the package author on that PR. I care enough about this issue that I may start a discussion on a Python mailing list about it. Not sure which one though.
@alex_gaynor: if I wanted to convince some heavy hitters in the Python community that relative imports within packages should be a best practice, how would you recommend going about that?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2752
To: pulkit, #hg-reviewers
Cc: alex_gaynor, indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list