D2934: forget: add --confirm option

av6 (Anton Shestakov) phabricator at mercurial-scm.org
Thu Mar 22 11:39:49 EDT 2018


av6 added inline comments.

INLINE COMMENTS

> cmdutil.py:2007
> +    if dryrun and confirm:
> +        raise error.Abort(_("can't specify --dry-run and --confirm"))
>      join = lambda f: os.path.join(prefix, f)

"cannot specify both --dry-run and --confirm" is the style used in other commands.

> commands.py:2043
>      '^forget',
> -    walkopts + dryrunopts,
> +    walkopts + dryrunopts + confirmopts,
>      _('[OPTION]... FILE...'), inferrepo=True)

Looks like test-completion.t also needs to be updated.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2934

To: khanchi97, #hg-reviewers
Cc: av6, mercurial-devel


More information about the Mercurial-devel mailing list