D2752: cbor: add a __init__.py to top level cbor module
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Sat Mar 24 12:01:30 EDT 2018
martinvonz added a comment.
In https://phab.mercurial-scm.org/D2752#45926, @pulkit wrote:
> In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote:
>
> > I think you should send the relative import patches to upstream. Adding `from __future__ import absolute_import` would also be a nice touch.
>
>
> I tried that at https://github.com/agronholm/cbor2/pull/20. I might be doing something wrong here but I am not sure what's that.
The relative imports are now done: https://github.com/agronholm/cbor2/commit/84181540f6eb650437e3f73cd104a65661fe8e67
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2752
To: pulkit, #hg-reviewers
Cc: martinvonz, alex_gaynor, indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list