D2594: graft: move logic to read current graft state file in state.py
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Sun Mar 25 02:32:58 EDT 2018
martinvonz added inline comments.
INLINE COMMENTS
> state.py:117-120
> + at readoldstatefile('graftstate')
> +def oldgraftstate(fp):
> + nodes = fp.read().splitlines()
> + return {'nodes': nodes}
Shouldn't this code be in commands.py? I don't think we should centralize the code for parsing all old formats in state.py. That will not happen with third-party extensions anyway, of course.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2594
To: pulkit, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list