D2591: state: import the file to write state files from evolve extension

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Mar 27 09:16:43 EDT 2018


yuja added inline comments.

INLINE COMMENTS

> state.py:55
> +    def __nonzero__(self):
> +        return self.exists()
> +

Nit: this seems too clever. I wouldn't expect `if state` issues a system call.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2591

To: pulkit, #hg-reviewers, indygreg
Cc: yuja, indygreg, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list