D2593: state: add logic to parse the state file in old way if cbor fails

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Mar 27 10:58:26 EDT 2018


martinvonz added inline comments.

INLINE COMMENTS

> pulkit wrote in state.py:84
> I don't feel convinced on what can be the benefit of it and my opinion can be influenced by how I used it in evolve extension. But I can change it the other way around too, let me know if you want me to change.

If it's up to me, I'd definitely say that you should change it. I don't see any benefits of the current proposal. I'd be happy to hear what other reviewers think.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2593

To: pulkit, #hg-reviewers
Cc: martinvonz, indygreg, durin42, mercurial-devel


More information about the Mercurial-devel mailing list