[PATCH V3] remove: add dry-run functionality

[sushil khanchi]

yeah, It's not working with largefiles. I am trying to solve this issue.

On Sat, Mar 24, 2018 at 8:19 AM, Yuya Nishihara <yuya at tcha.org> wrote:

> On Sat, 24 Mar 2018 01:32:13 +0530, Sushil khanchi wrote:
> > # HG changeset patch
> > # User Sushil khanchi <sushilkhanchi97 at gmail.com>
> > # Date 1521655571 -19800
> > #      Wed Mar 21 23:36:11 2018 +0530
> > # Node ID d63af67f326c7478e062d55fd508012beb164a6e
> > # Parent  b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd
> > remove: add dry-run functionality
> >
> > diff -r b6a4881cec19 -r d63af67f326c hgext/largefiles/overrides.py
> > --- a/hgext/largefiles/overrides.py   Sun Mar 18 15:32:49 2018 -0400
> > +++ b/hgext/largefiles/overrides.py   Wed Mar 21 23:36:11 2018 +0530
> > @@ -271,9 +271,11 @@
> >      bad.extend(f for f in lbad)
> >      return bad
> >
> > -def cmdutilremove(orig, ui, repo, matcher, prefix, after, force,
> subrepos):
> > +def cmdutilremove(orig, ui, repo, matcher, prefix, after, force,
> subrepos,
> > +                  dryrun):
> >      normalmatcher = composenormalfilematcher(matcher,
> repo[None].manifest())
> > -    result = orig(ui, repo, normalmatcher, prefix, after, force,
> subrepos)
> > +    result = orig(ui, repo, normalmatcher, prefix, after, force,
> subrepos,
> > +                  dryrun)
> >      return removelargefiles(ui, repo, False, matcher, after=after,
> >                              force=force) or result
>
> Can you add a test for largefiles?
>
> I think removelargefiles() would have unwanted effect on --dry-run.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180328/dea80477/attachment.html>