D2897: fix: new extension for automatically modifying file contents

[pulkit (Pulkit Goyal)]

pulkit added subscribers: indygreg, yuja, martinvonz, krbullock, durin42.
pulkit added a comment.


  The code except of minor nits looks good to me. I will like others to chime in on whether we should rename the command and extension to `format` because `fix` is too generic. I will push it once we get the naming and these comments sorted out.
  cc: @yuja @indygreg @martinvonz @durin42 @krbullock

INLINE COMMENTS

> test-fix.t:813
> +
> +It's also possible that the child needs absolutely no changes, but we still
> +need to replace it to update its parent. If we simply skip replacing it because

This should respect `experimental.evolution.allowunstable` and error out if set to False.

> test-fix.t:838
> +
> +Similar to the case above, the child revision may become empty as a result of
> +fixing its parent. We should still create an empty replacement child.

I am not sure how it should interact with `ui.allowemptycommit`. Maybe add a TODO here about this.

> test-fix.t:857
> +  
> +  @  1 edit foo
> +  |   foo.whole |  2 +-

When the working directory parent get obsoleted because of `fix`, we should update to it's successor similar to what other commands do.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2897

To: hooper, #hg-reviewers
Cc: durin42, krbullock, martinvonz, yuja, indygreg, pulkit, mercurial-devel