D2959: stringutil: add isauthorwellformed function
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Wed Mar 28 09:17:02 EDT 2018
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
Looks mostly good, but can you fix these nits?
INLINE COMMENTS
> stringutil.py:290
> +
> +_correctauthorformat = remod.compile('^[^<]+\s\<[^<>]+@[^<>]+\>$')
> +def isauthorwellformed(author):
Nit: add br'' for Python 3 compatibility.
> stringutil.py:295
> +
> + >>> isauthorwellformed('Good Author <good at author.com>')
> + True
b'' for Python 3 compatibility.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2959
To: sheehan, #hg-reviewers, yuja
Cc: yuja, av6, mercurial-devel
More information about the Mercurial-devel
mailing list