D2591: state: import the file to write state files from evolve extension

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Mar 28 14:22:48 EDT 2018


indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> yuja wrote in state.py:55
> Nit: this seems too clever. I wouldn't expect `if state` issues a system call.

I agree. Let's not implement `__nonzero__`.

> state.py:79
> +        with self._repo.vfs(self.fname, 'wb', atomictemp=True) as fp:
> +            cbor.dump(self.opts, fp)
> +

We probably want `canonical=True` here so behavior is deterministic. All that does in reality is sort dicts and sets. I doubt we have any data structures large enough for this to be a problem.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2591

To: pulkit, #hg-reviewers, indygreg
Cc: yuja, indygreg, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list