D2096: infinitepush: move the extension to core from fb-hgext

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Mar 30 15:03:45 EDT 2018


indygreg added inline comments.

INLINE COMMENTS

> __init__.py:136
> +    common,
> +    infinitepushcommands,
> +)

This deleted module isn't dropped later in the series.

> __init__.py:266
> +        self._repo = repo
> +        storetype = self._repo.ui.config('infinitepush', 'storetype', '')
> +        if storetype == 'disk':

Default value can be dropped.

> __init__.py:276
> +
> +        indextype = self._repo.ui.config('infinitepush', 'indextype', '')
> +        if indextype == 'disk':

Default value can be dropped.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2096

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list