D2988: fix: use a portable python script instead of sed in test
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Fri Mar 30 22:56:39 EDT 2018
mharbison72 added a comment.
sys.std* need the procutil.setbinary() treatment, and globbing applied to the delta below to keep Windows happy. Also, test-fix-topology.t probably needs the same fix.
--- c:/Users/Matt/projects/hg/tests/test-fix.t
+++ c:/Users/Matt/projects/hg/tests/test-fix.t.err
@@ -930,7 +935,7 @@
$ hg commit -Aqm "foo"
$ printf "Foo\nbar\nBaz\n" > foo.changed
$ hg --debug fix --working-dir
- subprocess: /usr/bin/python $TESTTMP/uppercase.py 1-1 3-3
+ subprocess: c:/Python27/python.exe $TESTTMP/uppercase.py 1-1 3-3
$ cd ..
I'm not sure if you have any idea why, but it seems like {rootpath} is getting lost on Windows. (The changes here are because the printfs don't get run properly on Windows when run directly.)
https://www.mercurial-scm.org/pipermail/mercurial-devel/2018-March/114691.html
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2988
To: hooper, #hg-reviewers
Cc: mharbison72, mercurial-devel
More information about the Mercurial-devel
mailing list