D3433: httppeer: detect redirect to URL without query string (issue5860)

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu May 3 16:40:18 EDT 2018


indygreg added inline comments.

INLINE COMMENTS

> mharbison72 wrote in test-http-protocol.t:361
> That makes sense.  And test-wsgirequest.py does run on Windows.
> 
> What baffles me is that the header that's printed (e.g. line 393) is correct on Windows with either URL.  So I have no idea where it could have divergent behavior.
> 
> Should I change the LFS behavior now, or punt because it's experimental?

You should consider changing it. But since it is experimental, it isn't critical. We can always do it in 4.6.1 if it is a problem in the wild.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3433

To: indygreg, #hg-reviewers
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list