D3433: httppeer: detect redirect to URL without query string (issue5860)
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri May 4 20:57:41 EDT 2018
yuja added inline comments.
INLINE COMMENTS
> httppeer.py:894
> + resp = sendrequest(ui, opener, req)
> + respurl, ct, resp = parsev1commandresponse(ui, url, requrl, qs, resp,
> + compressible=False,
Nit: `baseurl=url` seems not correct here since we've explicitly followed the redirect.
Anyway, this isn't a blocker as the `baseurl` (and `safeurl`) are used only for error
reporting.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3433
To: indygreg, #hg-reviewers
Cc: yuja, martinvonz, mharbison72, mercurial-devel
More information about the Mercurial-devel
mailing list