D3441: pycompat: export queue module instead of symbols in module (API)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Sun May 6 00:18:40 EDT 2018


martinvonz accepted this revision.
martinvonz added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> check-code.py:343-344
>      (r'^import atexit', "don't use atexit, use ui.atexit"),
> -    (r'^import Queue', "don't use Queue, use util.queue + util.empty"),
> +    (r'^import Queue', "don't use Queue, use pycompat.queue.queue + "
> +                       "pycompat.queue.empty"),
>      (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),

Maybe these should be "pycompat.queue.Queue" and "pycompat.queue.Empty" instead?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3441

To: indygreg, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list