D3439: template filters: add commonprefix

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sun May 6 08:29:25 EDT 2018


yuja added a comment.


  Can you add test for failure cases? such as
  
  - `str|commonprefix`
  - `int|commonprefix`
  - nothing common (e.g. `["/foo", "bar"]`)
  - empty list
  - paths normalized by `os.path.normcase()`
  
  `os.path.commonprefix()` isn't what we want, but it might provide some hints.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3439

To: joerg.sonnenberger, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list