D3459: shortest: rename "test" variable to "prefix"
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue May 8 08:47:23 EDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6921d3ecadc1: shortest: rename "test" variable to "prefix" (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3459?vs=8484&id=8513
REVISION DETAIL
https://phab.mercurial-scm.org/D3459
AFFECTED FILES
mercurial/revlog.py
CHANGE DETAILS
diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -1502,21 +1502,21 @@
def shortest(self, node, minlength=1):
"""Find the shortest unambiguous prefix that matches node."""
- def isvalid(test):
+ def isvalid(prefix):
try:
- if self._partialmatch(test) is None:
+ if self._partialmatch(prefix) is None:
return False
except error.RevlogError:
return False
except error.WdirUnsupported:
# single 'ff...' match
return True
try:
- i = int(test)
+ i = int(prefix)
# if we are a pure int, then starting with zero will not be
# confused as a rev; or, obviously, if the int is larger
# than the value of the tip rev
- if test[0] == '0' or i > len(self):
+ if prefix[0] == '0' or i > len(self):
return True
return False
except ValueError:
@@ -1527,9 +1527,9 @@
startlength = max(6, minlength)
length = startlength
while True:
- test = hexnode[:length]
- if isvalid(test):
- shortest = test
+ prefix = hexnode[:length]
+ if isvalid(prefix):
+ shortest = prefix
if length == minlength or length > startlength:
return shortest
length -= 1
To: martinvonz, indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list