[PATCH 3 of 3] sshserver: redirect stdin/stdout early and use duplicated streams

Augie Fackler raf at durin42.com
Fri May 11 00:41:16 EDT 2018


On Mon, May 07, 2018 at 10:11:24PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1521964053 -32400
> #      Sun Mar 25 16:47:33 2018 +0900
> # Node ID a7e53b70e5026bac9772f9869e754a2a6f530587
> # Parent  ea801aa5d559e37f68fb9bdda47dec6e58abcb88
> sshserver: redirect stdin/stdout early and use duplicated streams

queued these

>
> This is what we achieved with hook.redirect(True) plus ui.fout = ui.ferr.
>
> The hook.redirect() function can't be completely removed yet since hgweb
> still depends on it. I'm not sure if it is necessary for WSGI servers. CGI
> needs it, but does WSGI communicate over stdin/stdout channels?

I don't think it's required, but it's at least polite to not spew
things on stderr etc in WSGI.


More information about the Mercurial-devel mailing list