D3502: shortest: move revnum-disambiguation out of revlog

Yuya Nishihara yuya at tcha.org
Fri May 11 10:19:41 EDT 2018


> +    def disambiguate(prefix):
> +        """Disambiguate against revnums."""
> +        hexnode = hex(node)
> +        for length in range(len(prefix), 41):

Nit: `range(len(prefix), len(hexnode) + 1)` seems slightly better than
using a magic number outside the revlog module.

> +            prefix = hexnode[:length]
> +            if not isrev(prefix):
> +                return prefix


More information about the Mercurial-devel mailing list