[PATCH] phabricator: drop support for the deprecated `phabricator.token` config

Gregory Szorc gregory.szorc at gmail.com
Fri May 11 23:44:34 EDT 2018


On Fri, May 11, 2018 at 8:01 PM, Matt Harbison <mharbison72 at gmail.com>
wrote:

> On Fri, 11 May 2018 22:51:27 -0400, Yuya Nishihara <yuya at tcha.org> wrote:
>
> On Fri, 11 May 2018 21:31:48 -0400, Matt Harbison wrote:
>>
>>> > phabricator: drop support for the deprecated `phabricator.token` config
>>>
>>> BTW, are there any plans to move this into the bundled extensions?
>>>
>>
>> Perhaps someone will have to spend some time on making it testable.
>>
>> FWIW, the new config section [phabricator.auth] is incompatible with the
>> --config=section.name=value syntax. We'll need to rename it.
>>
>
> I wonder why it wasn't just folded into the existing [auth] config
> section, and maybe rename 'token' to 'password'.


+1 to moving it into [auth].

Since Phabricator's authentication is supplemental to HTTP authentication
(which is what the "password" config options would be for), we should
probably name the option "phabtoken" or something.


>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180511/144aa8f3/attachment.html>


More information about the Mercurial-devel mailing list