D3536: json: reject unicode on py2 as well

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat May 12 01:52:13 EDT 2018


yuja added a comment.


  >   `unicode` is not a type on Python 3. I think this should be changed to `(str, pycompat.unicode)`.
  
  Alternatively, it could be `type(u'')`. I have no preference though.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3536

To: martinvonz, #hg-reviewers, indygreg
Cc: yuja, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list