[PATCH] phabricator: drop support for the deprecated `phabricator.token` config

[Augie Fackler]

> On May 11, 2018, at 9:31 PM, Matt Harbison <mharbison72 at gmail.com> wrote:
> 
> BTW, are there any plans to move this into the bundled extensions?

Broadly, yes. The big blocker is having a testing story, because right now the “best” options I’ve heard are:

1) use a docker container to spin up an entire phabricator for testing
2) some kind replay mechanism on http traffic so we can verify the right requests are still being made

I think we’re all very in favor of (2), but haven’t had the time.

> I dabbled with Reviewboard this week, but I like how this can download a series, remember what review a commit is associated with, etc.  Bundling it would be nice for juggling different versions of Mercurial.  But Augie's comment on the bug tracker[1] made me think that maybe it's too hard to support properly.

I haven’t used reviewboard in a while, but Mozilla is moving from RB to Phab, which was enough to convince me to not go back and look at RB again.