[PATCH 2 of 3] sshserver: do setbinary() by caller (API)

[Yuya Nishihara]

On Sat, 12 May 2018 17:49:30 -0400, Matt Harbison wrote:
> On Mon, 07 May 2018 09:11:23 -0400, Yuya Nishihara <yuya at tcha.org> wrote:
> 
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1521963324 -32400
> > #      Sun Mar 25 16:35:24 2018 +0900
> > # Node ID ea801aa5d559e37f68fb9bdda47dec6e58abcb88
> > # Parent  2be95f3cc4f8a4b59f7c50af093ea033d1d09c5e
> > sshserver: do setbinary() by caller (API)
> 
> This seems to be the cause of the recent odd test failures on Windows.   
> I'm not in front of the testbot machine, but test-http-branchmap.t is  
> hanging on my laptop here:
> 
> SALT1526160986 87 0
> + hg -R b ci -m baz
> + echo SALT1526160986 88 0
> SALT1526160986 88 0
> + hg push -R b -e '"c:/Python27/python.exe" oldhg' ssh://dummy/ --encoding  
> latin1

Fixed. I'll send the patches shortly.

> For whatever reason, -t30 doesn't cause the test to timeout.  If I kill  
> the python.exe doing the push, the test passes(!), and the server shuts  
> down properly.  I suspect a flush is missing, but I've no idea where.

Some blocking I/O can't be interrupted on Windows.