D3569: py3: convert the report to bytes

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed May 16 07:42:18 EDT 2018


yuja added a comment.


  >   - a/mercurial/dispatch.py +++ b/mercurial/dispatch.py @@ -1028,7 +1028,7 @@ '** which supports versions %s of Mercurial.\n' '** Please disable %s and try your action again.\n' '** If that fixes the bug please report it to %s\n')
  > - % (name, testedwith, name, report)) +                   % (name, testedwith, name, pycompat.bytestr(report)))
  
  Maybe stringutil.forcebytestr()?
  
  The report must be bytes, but a broken extension might provide a unicode
  for example, and a unicode can't always be byte-ified with bytestr().

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3569

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list