D3579: state: write the version number in plain text on top of state files

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri May 18 17:12:22 EDT 2018


martinvonz requested changes to this revision.
martinvonz added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> state.py:60-62
> +        try:
> +            iv = int(version)
> +        except ValueError:

why not `if not isinstance(version, int):`?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3579

To: pulkit, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list