D3606: py3: make sure we open files in bytes mode
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Sat May 19 15:39:43 EDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1978abdb216c: py3: make sure we open files in bytes mode (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3606?vs=8777&id=8810
REVISION DETAIL
https://phab.mercurial-scm.org/D3606
AFFECTED FILES
hgext/churn.py
mercurial/crecord.py
CHANGE DETAILS
diff --git a/mercurial/crecord.py b/mercurial/crecord.py
--- a/mercurial/crecord.py
+++ b/mercurial/crecord.py
@@ -554,7 +554,7 @@
"""
chunkselector = curseschunkselector(headerlist, ui, operation)
if testfn and os.path.exists(testfn):
- testf = open(testfn)
+ testf = open(testfn, 'rb')
testcommands = [x.rstrip('\n') for x in testf.readlines()]
testf.close()
while True:
diff --git a/hgext/churn.py b/hgext/churn.py
--- a/hgext/churn.py
+++ b/hgext/churn.py
@@ -161,7 +161,7 @@
if not aliases and os.path.exists(repo.wjoin('.hgchurn')):
aliases = repo.wjoin('.hgchurn')
if aliases:
- for l in open(aliases, "r"):
+ for l in open(aliases, "rb"):
try:
alias, actual = l.rsplit('=' in l and '=' or None, 1)
amap[alias.strip()] = actual.strip()
To: pulkit, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list