D2721: util: observable proxy objects for sockets

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Sun May 20 05:08:58 EDT 2018


pulkit added inline comments.

INLINE COMMENTS

> util.py:1019
> +        self.fh.write('%s> setsockopt(%r, %r, %r) -> %r\n' % (
> +            self.name, level, optname, value))
> +

If I am understanding this correctly, this can lead to `TypeError: not enough arguments for format string`

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2721

To: indygreg, #hg-reviewers, durin42
Cc: pulkit, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list