D3612: py3: use pycompat.fsencode() to convert tempfile name to bytes

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon May 21 08:58:04 EDT 2018


yuja added a comment.


  >   bundle = None
  >   try:  # guards bundle
  > 
  > - bundlepath = "bundle:%s+%s" % (op.repo.root, bundlefile) +        bundlepath = "bundle:%s+%s" % (op.repo.root, +                                       pycompat.fsencode(bundlefile))
  
  It's probably better to handle this by callers because a filename passed
  to a Mercurial function should always be bytes.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3612

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list