D3614: py3: check for None before comparing with integers

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon May 21 09:11:18 EDT 2018

yuja added a comment.

  >   - a/mercurial/revlog.py +++ b/mercurial/revlog.py @@ -846,7 +846,7 @@ def rawsize(self, rev): """return the length of the uncompressed text for a given revision""" l = self.index[rev][2]
  > - if l >= 0: +        if l is not None and l >= 0:
  Ugh, rawsize could be None? It smells like a bug.

  rHG Mercurial


To: pulkit, indygreg, #hg-reviewers
Cc: yuja, mercurial-devel

More information about the Mercurial-devel mailing list