D3620: tests: fix test-patch.t on picker /bin/sh implementations
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu May 24 12:41:03 EDT 2018
martinvonz added a comment.
In https://phab.mercurial-scm.org/D3620#57369, @durin42 wrote:
> In https://phab.mercurial-scm.org/D3620#57367, @martinvonz wrote:
> > > FreeBSD sh(1) doesn't accept -d, so we weren't testing what we
> > > expected there. Let's just use a simple Python script instead.
> > This confused me for longer than it should. I assume you just mean -c instead of -d.
> No, I actually mean -d. We *add* `-d $PWD` to the invocation of the patch tool internally before invoking it.
Hmm, so we were hoping that whatever `sh` implementation was used would support a -d option and would not fail when it was given $PWD? That's a really odd assumption, so thanks for cleaning that up. Do other shells (than FreeBSD) support a -d option (bash and dash don't seem to)?
To: durin42, #hg-reviewers, pulkit
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel