[PATCH 1 of 2 RESEND] extensions: peek command table of disabled extensions without importing

Martin von Zweigbergk martinvonz at google.com
Sat May 26 01:06:52 EDT 2018


On Thu, May 24, 2018 at 6:57 AM Yuya Nishihara <yuya at tcha.org> wrote:

> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1525340282 -32400
> #      Thu May 03 18:38:02 2018 +0900
> # Node ID a9b271c7d3c095c381da92be0ad7bfd2e9555ac9
> # Parent  c3960c7e66fad7436f1a550ef1de693a635faa3a
> extensions: peek command table of disabled extensions without importing
>

Queuing this, thanks.

We once had a bug where `hg help` would crash because it ended up importing
all the extensions we ship with core even though they were not enabled. The
narrow extension that ships with core (which we had not enabled) did stuff
at import time that conflicted with what the external narrowhg extension
(which we had enabled). They both tried registered a revlog flag processor
and it's an error to register two processors for the same flag. I suspect
this patch would prevent such things from happening again.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180525/38a24228/attachment.html>


More information about the Mercurial-devel mailing list