[PATCH 3 of 3 RFC] revset: add an 'all' argument to ancestor() to return

[Sean Farley]

Yuya Nishihara <yuya at tcha.org> writes:

> On Mon, 28 May 2018 21:27:40 +0900, Yuya Nishihara wrote:
>> On Sun, 27 May 2018 13:48:18 +0200, Sean Farley wrote:
>> > # HG changeset patch
>> > # User Sean Farley <sean at farley.io>
>> > # Date 1527357855 -7200
>> > #      Sat May 26 20:04:15 2018 +0200
>> > # Node ID 9fa3f81f4685ca73393f57253f2f05a0d758c022
>> > # Parent  000e9442997b1c61ae02a27e657ffb34d170502b
>> > # EXP-Topic gca-revset
>> > revset: add an 'all' argument to ancestor() to return
>> >
>> > Currently, I'm not sure if this should be an option or a new revset
>> > method.
>>
>> Maybe this can be an optimized path for 'heads(::x, ::y)'?
>> commonancestorsheads() is documented as such.
>
> To be clear, I thought this should be a new revset function since 'all' could
> also mean "all ancestors." And I noticed that it could be a private function
> '_ancestorheads(x, y)' rewritten from 'heads(::x, ::y)'.

Yeah, I think I agree that it should be a new revset; thanks. I'm not
quite sure what optimization you mean for heads(::x, ::y), though?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180528/715f13f8/attachment.sig>