D3187: phase: add dry-run functionality

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue May 29 15:35:51 EDT 2018


pulkit added a comment.


  Nice work! I like where how you simplified things from previous version.
  
  If you look at the patch, this seems to do multiple things at once which are:
  
  - adding dry-run argument to advanceboundary and retractboundary functions
  - adding a new --dry-run flag to hg phase
  
  Let's break things up in individual patches so that we can improve more on individual pieces. Can you split this into a separate patch for adding dryrun argument to each function, i.e. one patch for adcanceboundary, one for retractboundary, and then one last patch which adds the new flag? That will be very much helpful in reviewing this work and also making incremental changes and moving forward step by step.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3187

To: khanchi97, pulkit, #hg-reviewers
Cc: av6, mercurial-devel


More information about the Mercurial-devel mailing list