D3665: graph: improve graph output by using Unicode characters
johnstiles (John Stiles)
phabricator at mercurial-scm.org
Tue May 29 22:20:12 EDT 2018
johnstiles added a comment.
In https://phab.mercurial-scm.org/D3665#57649, @smf wrote:
> johnstiles (John Stiles) <phabricator at mercurial-scm.org> writes:
> > johnstiles added a comment.
> > yuya, I believe these patches should address all of your concerns except for `encoding._wide`. I am not sure what your expectation is for that. I don't think it would make sense to silently disable the extension if `encoding._wide` is set; IMO that would cause user confusion. If a user sees that the log lines are not lining up properly, that is easy to understand, diagnose and fix (change your Terminal font). If the extension just silently doesn't work, that is much harder to fix.
> > Let me know if you see anything else that you would like addressed! Thanks :)
> Oh, crazy. I just started hacking something like this up last week. I'll
> have to check this out.
> - F93615: signature.asc <https://phab.mercurial-scm.org/F93615>
Awesome! Great minds think alike ;)
If you figure out a way to improve the look of diagonal lines transitioning into a straight vertical line, let me know... I'm still not in love with those. We need more box characters!
To: johnstiles, #hg-reviewers
Cc: smf, yuja, mercurial-devel
More information about the Mercurial-devel