[Bug 5902] New: lfs crashes in TortoiseHg when enabled only at the repo level

[mercurial-bugs at mercurial-scm.org]

https://bz.mercurial-scm.org/show_bug.cgi?id=5902

            Bug ID: 5902
           Summary: lfs crashes in TortoiseHg when enabled only at the
                    repo level
           Product: Mercurial
           Version: 4.6
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: lfs
          Assignee: bugzilla at mercurial-scm.org
          Reporter: matt_harbison at yahoo.com
                CC: mercurial-devel at mercurial-scm.org

I'm not sure if this is a thg bug for not isolating the extension, or an
extension bug, because it operates on a repo that didn't get reposetup() called
on it.  I suspect the latter.  I had a repo open in one tab with lfs enabled
locally, and the Mercurial tab visible without lfs.  I clicked something in the
Mercurial repo, and got this:

    #!python
    ** Mercurial version (4.6).  TortoiseHg version (4.6)
    ** Command: --nofork workbench
    ** CWD: C:\Users\mharbison\Desktop
    ** Encoding: cp1252
    ** Extensions loaded: eol, extdiff, mercurial_keyring, purge, rebase,
schemes, share, shelve, strip, reviewboard, evolve,
tortoisehg.util.configitems, lfs
    ** Python version: 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:53:40)
[MSC v.1500 64 bit (AMD64)]
    ** Windows version: sys.getwindowsversion(major=6, minor=2, build=9200,
platform=2, service_pack='')
    ** Processor architecture: x64
    ** Qt-5.9.2 PyQt-5.9.1 QScintilla-2.10.2.dev1711012104
    Traceback (most recent call last):
      File "tortoisehg\hgqt\revdetails.pyo", line 392, in _onFileSelected
      File "tortoisehg\hgqt\fileview.pyo", line 492, in display
      File "tortoisehg\hgqt\filedata.pyo", line 464, in load
      File "mercurial\patch.pyo", line 2356, in diff
      File "mercurial\patch.pyo", line 2471, in diffhunks
      File "mercurial\scmutil.pyo", line 1371, in prefetchfiles
      File "mercurial\util.pyo", line 2966, in __call__
      File "hgext\lfs\wrapper.pyo", line 252, in _prefetchfiles
    AttributeError: '_fncachevfs' object has no attribute 'lfslocalblobstore'

It should be simple enough to check for the attribute in most wrapper functions
taking a repo or ctx, but I don't remember playing those games with largefiles.

-- 
You are receiving this mail because:
You are on the CC list for the bug.