D3665: graph: improve graph output by using Unicode characters
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Wed May 30 21:10:47 EDT 2018
indygreg added a comment.
I think this is a cool idea! I could nitpick some of the glyph choices (e.g. U+233E ⌾ is really small and harder to read than `@` and U+25CC ◌ looks like a circle and therefore the standard node type). But overall I like it!
We //could// roll this functionality into core pretty easily and put it behind an e.g. `ui.graph-unicode` config setting. Or we could find some way to templatize the graph characters so people could modify them more easily. Having all the edge and node characters hard-coded feels a bit awkward. But I think this is scope bloat and shouldn't block this feature from landing. Others may have different opinions...
> + def convertedges(line):
> + def prettyedge(before, edge, after):
These don't need to be nested functions / closures. Please move to the module level.
To: johnstiles, #hg-reviewers
Cc: indygreg, smf, yuja, mercurial-devel
More information about the Mercurial-devel