D3636: py3: use pycompat.fsencode() to convert user value to bytes

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Thu May 31 15:16:21 EDT 2018


durin42 added inline comments.

INLINE COMMENTS

> debugcommands.py:1403
>                  age = now - st[stat.ST_MTIME]
> -                user = util.username(st.st_uid)
> +                user = pycompat.fsencode(util.username(st.st_uid))
>                  locker = vfs.readlock(name)

Should util.username() instead consistently return bytes?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3636

To: pulkit, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list