D5196: changegroup: restore default node ordering (issue6001)

[lothiraldan (Boris Feld)]

lothiraldan added a comment.


  With the fix, we are back to pre-regression performance on the test suite.
  
  Can we update the last paragraph of the changeset description to replace it with the previous phrase?
  
  There is two tests that are actually slower between https://phab.mercurial-scm.org/rHGd9b3cc3d5d07fb864d2ebba2a17f784a583dbc65 (the parent of the regression) and the fix, which are:
  
    +         206±2ms         310±40ms     1.51  basic_commands.PushPullTimeSuite.time_push('mozilla-central-2018-08-01', 'local', 'same', 'default')
    +         175±1ms         226±30ms     1.30  basic_commands.PushPullTimeSuite.time_push('mozilla-central-2018-08-01', 'local', 'same', None)
  
  There are push operations between the same repository, no-op push. As they are no-op push, I think there is no bundle generation so the fix shouldn't impact the performance. We may have another slowdown.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5196

To: lothiraldan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel