D5209: statprof: add a couple of asserts to avoid storing unicodes
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Thu Nov 1 21:17:13 UTC 2018
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I don't feel strongly about this change, so it'd be fine to drop it
during review, but it was _extremely_ helpful in drafting the next
change.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5209
AFFECTED FILES
mercurial/statprof.py
CHANGE DETAILS
diff --git a/mercurial/statprof.py b/mercurial/statprof.py
--- a/mercurial/statprof.py
+++ b/mercurial/statprof.py
@@ -206,8 +206,10 @@
__slots__ = (u'path', u'lineno', u'function', u'source')
def __init__(self, path, lineno, function):
+ assert isinstance(path, bytes)
self.path = path
self.lineno = lineno
+ assert isinstance(function, bytes)
self.function = function
self.source = None
To: durin42, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list