D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state

[spectral (Kyle Lippincott)]

spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  (This is an attempt to make it more obvious that the indentation is correct, to
  prevent a repeat of https://phab.mercurial-scm.org/rHG97f52862b1bd3de913261e0aba7e1a35ceb9de12)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5215

AFFECTED FILES
  tests/run-tests.py

CHANGE DETAILS

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -1362,19 +1362,19 @@
                 script.append(b'%s %d 0\n' % (salt, line))
             else:
                 script.append(b'echo %s %d $?\n' % (salt, line))
-        active = []
+        activetrace = []
         session = str(uuid.uuid4())
         if PYTHON3:
             session = session.encode('ascii')
         hgcatapult = os.getenv('HGCATAPULTSERVERPIPE')
         def toggletrace(cmd=None):
             if not hgcatapult or hgcatapult == os.devnull:
                 return
 
-            if active:
+            if activetrace:
                 script.append(
                     b'echo END %s %s >> "$HGCATAPULTSERVERPIPE"\n' % (
-                        session, active[0]))
+                        session, activetrace[0]))
             if cmd is None:
                 return
 
@@ -1386,7 +1386,7 @@
             script.append(
                 b'echo START %s %s >> "$HGCATAPULTSERVERPIPE"\n' % (
                     session, quoted))
-            active[0:] = [quoted]
+            activetrace[0:] = [quoted]
 
         script = []
 
@@ -1527,7 +1527,7 @@
             after.setdefault(pos, []).append('  !!! missing #endif\n')
         addsalt(n + 1, False)
         # Need to end any current per-command trace
-        if active:
+        if activetrace:
             toggletrace()
         return salt, script, after, expected
 



To: spectral, #hg-reviewers
Cc: mercurial-devel