D5199: test: fix self._testdir to use ues the right mercurial library during testing

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Nov 2 21:44:19 EDT 2018


yuja added a comment.


  > - a/tests/run-tests.py +++ b/tests/run-tests.py @@ -2527,13 +2527,14 @@ os.umask(oldmask)
  > 
  >   def _run(self, testdescs): +        testdir = getcwdb()
  
  
  
  >   self._testdir = osenvironb[b'TESTDIR'] = getcwdb()
  
  Nit: maybe this line has to be removed.
  
  >   1. assume all tests in same folder for now if testdescs: pathname = os.path.dirname(testdescs[0]['path']) if pathname:
  > - osenvironb[b'TESTDIR'] = os.path.join(osenvironb[b'TESTDIR'],
  > - pathname) +                testdir = os.path.join(testdir,pathname) +        self._testdir = osenvironb[b'TESTDIR'] = testdir
  
  The idea sounds good, but test-run-tests.t failed. Can you investigate?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5199

To: sangeet259, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list